Template talk:Skill fact

From Guild Wars 2 Wiki
Jump to: navigation, search

Vista-file-manager.png
Archive


Varying duration value notations[edit]

Sample case. This might happen in the future, and I really don't know how to properly account for these. We could use 180secs for duration param sure, but it would look so out of place. I've been thinking about expanding misc and add a "flavor" parameter so we can avoid html tags all over this template, they just... don't feel right. We could simply wrap flavor text around a grey span (I'm sure this is how it goes for 99.9999999% of skills). Thoughts? – Valento msg 18:30, 29 January 2015 (UTC)

Breakstun Icon[edit]

In the game, the breakstun icon in the tooltips of skills that break out of control effects is a chain being snapped in half. I think we should change the icon of breakstun from it's current stun icon to what is in the game. Nicoli20 (talk) 00:11, 18 March 2015 (UTC)

Wow, that's been broken for a while, good catch. —Dr Ishmael User Dr ishmael Diablo the chicken.png 01:55, 18 March 2015 (UTC)

Skill fact rewrite[edit]

Skill fact rewrite is pretty much done. This involves a rewrite of the {{effect}} template at the same time. I went through most of the skills and traits and picked out anything that occurred often. That's where you see gain and remove from. The rest is factoring out the miscellaneous parameters, adding effect descriptions to everything, supporting effects, making generic properties, having a useful default case (pretty much replacing misc). Some facts like pull and area of effect don't appear anymore. I also fixed the example tables to make it more useful as a reference. I can add backwards compatibility, but stuff is going to break in any case and might as well fix everything. This makes the specific effect templates obsolete and most of them won't be affected by the changes to the effect template.--Relyk ~ talk < 00:26, 28 June 2015 (UTC)

Attunement and linked skill could be combined, since attunements are skills. —Dr Ishmael User Dr ishmael Diablo the chicken.png 01:38, 28 June 2015 (UTC)
How to use {{skill fact|property|(property name)|(value)}}? I wanted to implement it in https://wiki.guildwars2.com/index.php?title=Confounding_Suggestions&oldid=1032714 but it gave a error saying "The given value was not understood". Thanks. (The page used {{skill fact|Trigger Chance|100%}}. I tried {{skill fact|property|Trigger Chance|100%}} but still in vain.) --Fanolian (talk) 05:26, 29 June 2015 (UTC)
Health threshold (skill fact|threshold) should use a radius icon instead of the generic one. --Fanolian (talk) 06:48, 29 June 2015 (UTC)
It was an issue with {{trait infobox}}. threshold needs to be changed to health threshold eventually. There are a couple other threshold facts like range that use the generic fact iirc. Didn't add them becomes they were uncommon.--Relyk ~ talk < 07:02, 29 June 2015 (UTC)
In the section of Percentage modifiers, {{skill fact|duration increase}} does not support alt text while the other 3 do. This is a minor issue as I can always use {{skill fact|property}} for this type of property. It is just a matter of consistence (in the reference). :) --Fanolian (talk) 07:18, 29 June 2015 (UTC)
It's intentionally not consistent, the ones with alt text are the skill facts I saw needed alternate text. Another problem with duration increase is that there are duration facts for a fixed amount of seconds. I figure people should use a general property for those edge cases.--Relyk ~ talk < 08:01, 29 June 2015 (UTC)
Understood. I am editing Temporal_Enchanter but I cannot use {{skill fact|property|Duration Increase|2 s|icon=Radius.png}} to change the icon. For the example given in Template:Skill_fact, {{skill fact|Hits per Shell|5|icon=Stun.png}} works but not {{skill fact|property|Hits per Shell|5|icon=Stun.png}} --Fanolian (talk) 08:09, 29 June 2015 (UTC)
Property doesn't overload the icon parameter because all properties use the generic icon. If it's using a specific icon and terminology, the template needs to parameterize that. I think we need the template to be smart about checking whether the value is a percent or integer increase and format correctly--Relyk ~ talk < 08:14, 29 June 2015 (UTC)
The percent sign is annoying. We could use decimal values instead of requiring a percent sign if we assume no duration increases go below 1.--Relyk ~ talk < 08:29, 29 June 2015 (UTC)
Is there a way to distinguish 20% and 100% physical finishers now? Before it is done by {{skill fact|combo|projectile|suf=(20% chance)}}. Thanks. --Fanolian (talk) 09:40, 29 June 2015 (UTC)
I fixed the combo template earlier and forgot to add an example. I added an example, you specify y on the third parameter.--Relyk ~ talk < 18:46, 29 June 2015 (UTC)
That's... not intuitive at all. I'm not sure I like all the unnamed parameters that do different things depending on the value of the first one. —Dr Ishmael User Dr ishmael Diablo the chicken.png 18:54, 29 June 2015 (UTC)
How do I modify the display name of an effect? Decoy, for example, stealths but grants Hide in Shadows (effect). I tried {{skill fact|effect|[[Hide in Shadows (effect)|Stealth]]|3}} and {{skill fact|effect|Stealth|alt=Hide in Shadows (effect)|3}} but both fail. Another example is Protected Phantasms. The effect it grants is Phantasm Distortion instead of Distortion. But this one is really an edge case. In another news, most descriptions for stealth are broken due to the unavailability of {{skill fact|stealth|3}}.
The stack of stablility cannot be displayed, i.e. {{skill fact|stability|2|stacks=3}} is shown as
 Stability.png3 Stability (2s): Cannot be knocked down, pushed back, pulled, launched, stunned, dazed, floated, sunk, feared or taunted..
I've restored stacks to boons.
@Relyk: Why did you completely remove the ability to customize some options? Every option should be able to change the icon and the display text. Furthermore, every parameter listed in the generic "Parameters" section should be usable by every option. —Dr Ishmael User Dr ishmael Diablo the chicken.png 12:21, 29 June 2015 (UTC)
I didn't remove the ability to customize. You can customize the skill fact if you don't provide a type. The parameters section is not a generic list. We can change it to show which skill facts use specific parameters, like coefficient does.
We can provide a desc parameter to override the description for effect and have alt override the link text. The mismatched effect and link text was an edge case that I figured we'd push to the default case ({{skill fact|[[Hide in Shadows (effect)|Stealth]]|3 s|icon=Stealth.png}}), but we want the effect case to handle those.--Relyk ~ talk < 18:24, 29 June 2015 (UTC)
Given how the documentation is written, it looks like strikes and stacks should be usable no matter the value of parameter 1. But that's obviously not the case, so that needs to be rewritten to specify exactly when strikes/stacks can or can't be used. —Dr Ishmael User Dr ishmael Diablo the chicken.png 18:57, 29 June 2015 (UTC)
Should all boons and conditions be able to stack? Here's a screenshot all boons and conditions with stacks=5 appended: http://i.imgur.com/mS9d0nh.png. In addition, boons/conditions that stacks but having 1 stack only do not have an extra space between their icon and text, where the number of stacks should have been. Immobilize is the exception. It does not stack nor have an extra space. It looks bad in the template page. --Fanolian (talk) 04:36, 30 June 2015 (UTC)
One stack is implicit so we don't show it.--Relyk ~ talk < 16:14, 30 June 2015 (UTC)
Is it now safe to replace the misc calls in various trait skill facts with the new increase / decrease modifiers? I figured I'd go through Necro traits or something if it was. --Silenceaux (talk) 17:36, 29 June 2015 (UTC)
It should be because I didn't see any other edge cases.--Relyk ~ talk < 18:24, 29 June 2015 (UTC)

Use Template:Effect icon instead[edit]

Notably Daze and Stun have text errors in their description, putting articles like Mirror of Anguish into Category:Text errors. Without hovering over the icons, I never saw any text error on the articles that transclude those effects and this was very misleading—MoA didn't use {{sic}} or [[Category:Text errors]]. I had to dig through the DOM / ExpandTemplates to figure out what was causing this. Instead of {{effect|Daze}} can we do {{effect icon|Daze}} [[Daze]]? For all the effect icons? Mouseover description is redundant on effects (e.g. like Resistance) that display description afterward. —BryghtShadow (talk) 01:35, 7 July 2015 (UTC)

Mirror of Anguish is adding the page to Category:Text errors with {{effect description}}. You can see why that happens on Special:Browse/Daze. The actual problem is the sic being included when we define Property:Has game description in {{effect infobox}}. We can strip the template call out before defining the property.--Relyk ~ talk < 11:34, 7 July 2015 (UTC)
Oh yes, I'm all for the removal of sic when defining the property. --BryghtShadow (talk) 03:16, 8 July 2015 (UTC)
How exactly do you plan on doing that? The {{#replace}} function only works with literal strings, it can't do regex. And with {{sic}} taking a parameter (to describe the error), you can't just replace a literal. —Dr Ishmael User Dr ishmael Diablo the chicken.png 04:16, 8 July 2015 (UTC)
Like this!--Relyk ~ talk < 07:19, 8 July 2015 (UTC)
Well frak. I completely forgot about #dplreplace and that SMW pre-parses the values of text properties. Anyway, better get this on the other infoboxes, too. —Dr Ishmael User Dr ishmael Diablo the chicken.png 12:29, 8 July 2015 (UTC)
{{#dplreplace: What if the darn thing hasn {{sic|should be has}} more than one typoe {{sic|should be typo}}? |<span(.*)</span>|}}
What if the darn thing hasn
?
Maybe use something without greedy .* in it? -Chieftain AlexUser Chieftain Alex sig.png 12:40, 8 July 2015 (UTC)
{{#dplreplace: What if the darn thing hasn {{sic|should be has}} more than one typoe {{sic|should be typo}}? |<span(.*?)</span>|}}
What if the darn thing hasn
]]]</span>
more than one typoe
]]]</span>
?
That's even more fun, because template:sic has nested <span>s. —Dr Ishmael User Dr ishmael Diablo the chicken.png 12:47, 8 July 2015 (UTC)
{{#dplreplace:What if the darn thing hasn {{sic|should be has}} more than one typoe {{sic|should be typo}}? | /(.*?)\s?(<span.*?>[''\[\[wikipedia:sic\{{!}}<span.*?>sic<\/span>\]\]'']<\/span>)(?:\[\[category:text errors\]\])?/i|\1}}
What if the darn thing hasn
more than one typoe
?
See: "de-sic". Also removes the cat. --BryghtShadow (talk) 14:58, 8 July 2015 (UTC)
Yuck. I don't really like the idea of putting a lot of complex regex into our templates. It should be sufficient to simply remove the category and leave the sic tag, and that doesn't require any regex at all. —Dr Ishmael User Dr ishmael Diablo the chicken.png 15:10, 8 July 2015 (UTC)
Would it be horrible to suggest that we make each one of these skill facts into a subobject if used on a skill page? (defined for example by a variable in the infobox) It would be nice (read: I like popup hover things in my sandbox) to have a way to reproduce effects on another page. -Chieftain AlexUser Chieftain Alex sig.png 15:21, 8 July 2015 (UTC)
That was already planned until someone removed the proposal from Guild Wars 2 Wiki:Semantic MediaWiki/Skills :P One of the main reasons for the rewrite is defining more effect types and generalizing to make subobjects useful.--Relyk ~ talk < 15:11, 9 July 2015 (UTC)
this bit? What is set_internal anyway? #subobject? -Chieftain AlexUser Chieftain Alex sig.png 16:30, 9 July 2015 (UTC)
smw:Semantic Internal Objects - it's deprecated now in favor of subobjects. Originally an SIO worked something like an inverted subobject where the relationship pointed from the SIO to the parent page (and you had to specify the name of this property when creating the SIO), rather than the relationship being defined in Property:Has subobject pointing from the parent page to the subobject. —Dr Ishmael User Dr ishmael Diablo the chicken.png 16:44, 9 July 2015 (UTC)
I used the regex that targetted sic's format to avoid removing markup from other possible sources. I also chose to remove the leading space for scenarios where the {sic} was added before a punctuation. Here's a simpler one (is this still too complex?) that still removes leading space:
pattern = (.*?)\s?<span.*?>.*?<span.*?>sic</span>.*?</span>, replacement = \1
What if the darn thing hasn <div id="sic" style="display:inline; -webkit-user-select: none; -moz-user-select: none; -ms-user-select: none; user-select: none;"></div> more than one typoe <div id="sic" style="display:inline; -webkit-user-select: none; -moz-user-select: none; -ms-user-select: none; user-select: none;"></div>?
Simply removing the category may be sufficient, but the properties will still be filled with so much markup: [1]. I prefer my properties as clean as possible. IMO, markup from {sic} doesn't make sense for description, whereas linebreaks do (game uses '\n'). --BryghtShadow (talk) 16:15, 8 July 2015 (UTC)
The simple method is add id="outer-span" and do <span id="outer-span"(.*)]</span> I'd think. Removing the category is the most elegant solution though because the normal use for {{effect description}} should still have the sic.--Relyk ~ talk < 15:11, 9 July 2015 (UTC)
"normal use should still have the sic" That's exactly what I was thinking when I suggested that. —Dr Ishmael User Dr ishmael Diablo the chicken.png 15:21, 9 July 2015 (UTC)

Costume brawl missing[edit]

It seems the costume brawl parameters aren't used by this template anymore. This breaks facts in a lot of skill pages. Tyndel (talk) 06:20, 7 August 2015 (UTC)

Ok, we just use the effect parameter, makes sense. We could use a bot to update the skills that are affected. EDIT: And now I'm seeing it's already at work lol... Tyndel (talk) 08:20, 7 August 2015 (UTC)
manual editing with AWB sucks - the variables were too randomly written for a bot >.< -Chieftain AlexUser Chieftain Alex sig.png 08:57, 7 August 2015 (UTC)

Defiance bar damage and pull, knockback and launch disable durations[edit]

I think pull, knockback and launch should have an additional parameter for the disable duration. Pulls and knockbacks seem to always have 1.5s so that could be the default. Launches have 2.32 or 3.23. Listing defiance damage is but questionable since it can be calculated from the effect and duration. Conditions might look messy if they had defiance value on them. I didn't want to start editing the template right away in case I mess up royally. Any opinions? Wethospu (talk) 06:48, 5 May 2016 (UTC)

pre/suf options[edit]

Ran into suf= for the first time today while working on Asura Ice Wave, which seemed like a handy way to get some extra text into the skill fact where it was needed. However, it's use and existence aren't documented on the main page. Same thing with pre=, which I assume has a similar purpose. Could an example be added? SarielV 20 x 20px 04:51, 12 May 2017 (UTC)

The pre and suf parameters were there to generalize the template. After refactoring the template, I think this turned out to not be needed when I was working on it. This became even less so as AreaNet standardized most of the skill descriptions. Right now, they are only for backwards compatibility and I couldn't find any examples where we are still using them.--Relyk ~ talk < 18:59, 26 July 2017 (UTC)

Property[edit]

What exactly is "property" supposed to be used for? It looks like it does the same as "misc", just you can't change the icon. What am I missing here? - Doodleplex 22:02, 21 March 2018 (UTC)