Template talk:Vendor

Still needed

This still needs the guild bank, but I couldn't find if the icon had been uploaded yet. -- Wyn talk 14:08, 8 September 2012 (UTC)

Can somebody create the icon for the new sailor NPC service? I can't figure out how to do it myself. The image for the icon is here: --Strongbeard 06:23, 18 November 2012 (UTC)

So, yeah, it's five years late, but I added the little sailor icon:  :) Currently, it's only used for the Lionguard Aircrew NPC, who doesn't really have a map icon in-game, just an overhead icon. — Blackice (talk) 09:24, 4 November 2017 (UTC)

I literally went through and removed all these one-off options and added the misc option, why are we re-adding them? -Chieftain Alex 11:27, 4 November 2017 (UTC)

I only know of the misc option because I saw you adding them a while back. I don't think it's been stated anywhere to use the misc option over adding to these icon list templates. J.Tesla (talk) 14:52, 4 November 2017 (UTC)

Heart/Heartyes/Heartno parameter options

Are these necessary? All heart NPCs are only vendors when the heart's fulfilled making the last (heartno) pointless on this template, and all heart vendors are karma vendors and over the NPC itself uses the heartkarma icon; the heart/heartyes icon is only used on the map. So I don't think these are needed in this template. Konig/talk 02:57, 30 December 2012 (UTC)

The heartno parameter isn't used on a single page except Renown heart NPC.-- _talk 03:10, 30 December 2012 (UTC)

Karma armorsmith and Karma weaponsmith

I've added the logos for the karma smiths to the template. The karma weaponsmith currently is the same as the cultural armorsmith one, but for usability (and because they portray two distinct services) I kept them separated. ~ Sanna 11:09, 22 January 2013 (UTC)

Repair vendor link

Shouldn't {{vendor|repairs}} link to Repairs instead of Vendor#Repairs? I couldn't figure where the links are stored.. Flaicher (talk) 15:45, 26 August 2013 (UTC)

Fixed. Template:Vendor uses Template:Map icon, which is where the real work happens. —Dr Ishmael 15:52, 26 August 2013 (UTC)

Rename to "NPC icon"

Thoughts? -Chieftain Alex 15:49, 14 October 2017 (UTC)

I had the same idea and I thinks it's a good one. :) That'd avoid some confusion, considering there are lots of non-vendor NPC icons in this template, like: . — Blackice (talk) 12:10, 3 November 2017 (UTC)

If we make this template I suggest we do it differently. I think we should be able to write "{{NPC icon|<npc>}}" and show the map icon followed by a name that all links to that NPC page. To do this we can either save the map icon in the NPC infobox or connect the icons to to the NPC's service. The problem with the latter is that there are many unique icons and services that would need documenting so my preference is with the first option. J.Tesla (talk) 14:52, 4 November 2017 (UTC)

Broken and Complicated Parameters

Please compare Special:WhatLinksHere/Siege_Master_(PvP) with parameter siege master and Special:WhatLinksHere/Siege_Master_(WvW), something seems to be very wrong.. Siege Master (WvW) in every spawn and upgraded tower, keep, stonemist, making 10 per borderland and 15 on eb, in total 45 (not counting eotm) vs a single npc in pvp. Additionally making Skirmish Supervisor refer as skirmish merchant or Heroics Notary as hero challenges makes things unneccessary complicated. Another example: Doodle already changed my extremely complicated parameter ability-point reset merchant to a definitely nicer world ability master, but somehow the first parameter got reintroduced again. My suggestion: Keep it simple! Edit: Just found some broken {{vendor|weapon vendor}} and {{vendor|armor vendor}} tags. --Tolkyria (talk) 11:50, 3 November 2017 (UTC)

Hi Tolkyria, I found this template a while ago and tried to bring it somewhat up to date with the current state of the game, because I was bored. I tried to choose parameter names for the new icons that match exactly the in-game vendor titles and by that I mean the titles when hovering over their map icons and the the "[...]" tags right next to their names. Unfortunately, updating the WvW and PvP icons was though, because the game is horribly inconsistent about the vendor/service NPCs in these game modes. So for those reading along who are not familiar with the topic, here are some of the worst offenders:

• There's an NPC called Siege Master in WvW, who is referred to as "Siege Merchant" on his map icon and in the tag right next to his name. And then there's another NPC with the name Siege Master in the PvP lobby, who's map icon says "Siege Master" and who doesn't have a tag right next to the name. If we'd want to mirror the state of the game with this template then a {{vendor|siege master}} icon should probably refer to the PvP Siege Master, and a {{vendor|siege merchant}} to the WvW Siege Master. That wasn't the case previously, the {{vendor|siege master}} icon linked to the Siege Master (WvW) page, so I explicitly broke these links. I admit it sounds like a bit of a stretch, but I rather update 50 something pages than having these weird, old inconsistencies in the templates that never get fixed.
• About the Skirmish Supervisor and the Heroics Notary: The Supervisor is is called "Skirmish Merchant" on her map icon, and the Heroics Notary has the tag "Hero Challenges" right next to his name (i.e. he "sells" Hero Challenges). So, that's the reason for having two valid parameters for both of them. I'm really not sure which of these are supposed to be their names and which are their vendor job titles.
• So, then there are the equipment vendors in WvW. They have the names Weapon Master and Armor Master, and are called "Weaponsmith" and "Armorsmith" both on their map icons and in their tags. The old parameters for them were {{vendor|weapon vendor}} and {{vendor|armor vendor}}, which was crazy broad and ambiguous, considering that there are countless "weapon vendors" in several other places in the game.
• Then there's this little Asura devil of inconsistency: Name: Karma Trader, map icon: "Karma Merchant", and tag: "Equipment Trader". Unfortunately the old parameter for him was {{vendor|karma vendor}}, which is not in his list of titles and could refer to any of the other 100 Karma merchants in this game.
• Oh, and I almost forgot the Karma Trader's little cousin, the World Ability Master. Her map icon says "Ability-Point Reset Merchant" and the tag just "Merchant", because why not? I think, I removed the {{vendor|ability master}} param, but I don't know whether this was a good idea.

I'd prefer if we avoid reintroducing some of the old, misleading legacy parameters again and I'll try to fix the issues on the affected WvW pages and maybe some other stuff on the way — Blackice (talk) 13:27, 3 November 2017 (UTC)

Update: So, I actually went ahead and updated the affected WvW pages. At least Special:WhatLinksHere/Siege Master (PvP) seems clean now. At the same time, I fixed a couple of links to the WvW Siege Master's page, which were linking to the disambiguation page Siege Master instead of Siege Master (WvW). Not 100% sure whether I missed something or not. — Blackice (talk) 09:31, 4 November 2017 (UTC)

In my opinion the internal representation should be as simple as possible, see 1 pvp siege master occurrence vs more than 50 wvw ones, and might not mirror the ingame representation, as long as its external does. Regarding introducing new parameters: everyone can look it up in the template documentation to see the existing ones, so again in my opinion there's no need for providing first the merchant name and second the map merchant name as option. Since the usage of this template is mostly {{vendor|parameter}} [[Merchant name]] for me it makes sense that the parameter should be equal to the merchant name, i.e. {{vendor|Merchant name}} [[Merchant name]]

But nevertheless the WvW vendor part, as far as I checked it, should be correct now.. at least everything on these slightly rusted WvW pages is up to date now, thanks. --Tolkyria (talk) 16:44, 4 November 2017 (UTC)

Parameters update

Some old (supposedly unused) parameters got removed, leaving a few broken links (skill.png) around (seems they were still in use).
Could some bot please fix the following occurrences?

Look for	Replace with
{{vendor|armor vendor}}	{{vendor|armorsmith}}
{{vendor|weapon vendor}}	{{vendor|weaponsmith}}
{{vendor|speed boon}}	{{vendor|speed boons}}
{{vendor|guild commendation}}	{{vendor|guild commendation trader}}
{{vendor|guild vendor}}	{{vendor|guild promoter}}
{{vendor|wvw tutorial}}	{{vendor|instructor}}
{{vendor|ability master}}	{{vendor|ability-point reset merchant}}
{{vendor|gift}}	{{vendor|wintersday}}
{{vendor|gift exchange}}	{{vendor|wintersday}}
{{vendor|peppermint}}	{{vendor|wintersday}}

No idea if it would be an easy task for a bot/script (and if that'd be required to do some additional check for both "vendor" and "Vendor" template spellings - and parameter strings like "armor vendor", "Armor Vendor", "Armor vendor", "ARmoR VenDOr" and so on...), but it doesn't seem something anyone would enjoy to do on their own. --NIN37 03:07, 9 November 2017 (UTC)

Fixed some, added some back in since they shouldn't have been removed, everything should be good now. If you find anything else, let me know. =) - Do_odleplex 05:30, 9 November 2017 (UTC)

Thanks, Doodleplex! Send my regards to J.A.R.V.I.S. as well. :) --NIN37 23:34, 9 November 2017 (UTC)

Arena Vendor

Could File:PvP Arena Vendor.png -> Arena Vendor be added to the template? I've seen the PNG icon used in Champion's Rest and Hall of Memories, and it doesn't look nice (20 pixels is smaller, making text start a bit to the left; 24 pixels make the gap between lines wider). --NIN37 01:52, 10 November 2017 (UTC)