Template talk:Weapon infobox

From Guild Wars 2 Wiki
Jump to: navigation, search

Vista-file-manager.png
Archive



Uslot for white items[edit]

Can the template be updated so that you can put in "unused" as the uslot, and it will trigger the "unused upgrade slot" message to appear? Right now, it doesn't appear if there is also no description or prefix. I can sort of fudge it by putting in an alt+255 whitespace in the description, but that probably isn't idea. Psycho Robot (talk) 21:17, 10 January 2014 (UTC)

It should appear if uslot is defined, that would mean the description, prefix, or variables parameter is left blank.--Relyk ~ talk < 21:52, 10 January 2014 (UTC)
Yes, however if i put something like "unused" in, it attempts to pull up the upgrade component "unused", which doesn't exist, instead of displaying "unused upgrade slot". Psycho Robot (talk) 21:55, 10 January 2014 (UTC)
Ok, I remember I removed that logic in this revision because the parameter wasn't needed. I'm pretty sure I did that because all weapon have an upgrade slot and the only time we need to show an upgrade slot is when there's an item in it, which is limited to items that can only be obtained with the upgrade. We would only have a parameter to display unused if there are items that do not have an upgrade slot. I'm not sure if there's an example, otherwise I would've left the logic in.--Relyk ~ talk < 22:04, 10 January 2014 (UTC)
Starter aqua breathers do not have an upgrade slot. I don't know of any other piece of equipment that does not. I don't have a strong opinion on whether we should display whether there's an empty upgrade slot, I just thought maybe this behavior was unintentional. Psycho Robot (talk) 22:21, 10 January 2014 (UTC)

Skin parameter[edit]

Now that every single skin has an unique name, I think an autocategorized skin parameter should be added, for the skin that appears in the item's description. That way people can click the skin name in the infobox, go to the category page of that skin, and see a category automatically listing all items with that skin (e.g.: "Category: Soft Wood Focus skin items"). Then we could manually put those categories into sets (e.g. "Category: Priory skins"). MithUser MithranArkanere Star.pngTalk 19:36, 17 April 2014 (UTC)

This was a good idea, but we've run into a problem with name clashing - nearly every skin name is already being used as an entry for the weapon or armor piece that uses it. I've been getting around this by appending (skin) to the name of most of the entries, but this creates a few more difficulties:
1. The skin link requires the canonical name, which almost always becomes a self-reference for the page because the skin's canonical name is the same as the item name.
2. A lot of skins do not have unique names. This is mostly a problem for armor pieces, where several gem store skins have the same name across different weights. There are a few issues with weapons doing this too (namely the former Steamfire skin which is now Flame Trident). In this instance, just appending (skin) does not go far enough to allow for individual entries. In the few entries I've made that deal with this, I either specify the weight for armor (i.e. (heavy skin) ), or add more information in the parenthesis for weapons. Neither works well with the skin entry for this infobox. SarielV 20 x 20px 22:11, 2 December 2014 (UTC)
I tried proposing a separate namespace as a solution to this, but we couldn't come to a decision. Disambiguations would still be necessary for the special cases you mention of skins that have the same name, of course, but it would make all unique skin names so much easier to deal with. —Dr Ishmael User Dr ishmael Diablo the chicken.png 22:25, 2 December 2014 (UTC)

Defense shown as question mark[edit]

All shields have "?" listed as defense in the infobox, instead of the normal values. Could it be this change by BryghtShadow on the item stat lookup that caused this? —Ventriloquist 16:38, 19 November 2015 (UTC)

Quite right. BryghtShadow's edit meant that shields produced defense_lu : "x shield" - which it falsely interpreted as invalid. I've asked on their talk page to clarify why they wanted to "cleanup" invalid values. It'd need an explicit check for type_std=shield if it were to work at all. -Chieftain AlexUser Chieftain Alex sig.png 17:48, 19 November 2015 (UTC)

Seraph stats[edit]

We have a new stat called Seraph (https://api.guildwars2.com/v2/itemstats/1222). Could we get the template to allow for this? -Darqam 18:25, 9 February 2017 (UTC)

Should be good to go in any infobox. -Chieftain AlexUser Chieftain Alex sig.png 19:35, 9 February 2017 (UTC)

Collection parameter missing[edit]

collection parameter is missing in the description. The F. Prince (talk) 16:57, 31 March 2017 (UTC)

Prefixes[edit]

Would it be possible for the prefix to show up in the infoboxes of weapons and armors with predefined stats, such as Lepidoptera? It would save users (like me) the hassle of comparing the piece of equipment's stats with a list of prefixes to get the stats' name. Prefixes are already in the code, it would only be a matter of making them show up on the actual page. --Faelys 21:47, 5 June 2017 (UTC)

Items with multiple skins[edit]

Some items unlock multiple skins. This is usually noted at the bottom of each item's page. However, there are some items which display multiple skins at once, inside the infobox itself. Some examples:

I don't think the infobox is the right location to place this information. The field should be limited to one skin only, the default skin of the item. Other unlocked skins should be noted down elsewhere.--Lon-ami (talk) 18:31, 1 February 2019 (UTC)

But why? The idea behind the two skins per one item is to give the weapon user the possiblity to decide which skin he/she wants to use for his/her weapon. It seems like if the ingame possibility of choosing a skin for a weapon exists, they would have used this. Since it doesn't, they give the weapon one skin and furthermore on accountbind second skin is unlocked. Summing up, the current implementation is fine for me. --Tolkyria (talk) 19:28, 1 February 2019 (UTC)
That's more of what a gallery is for, you will be going to the skin pages instead of the weapons pages for choosing skins. We can update to match the default_skin from the API. Cavalier Axe Skin is an item, not equipment, so it doesn't have a default to rely on. We put the source piece of equipment for skin unlocks on the equipment page. We'll have to move the "Unlocked by item" relationship to the skin infobox.--Relyk ~ talk < 19:35, 1 February 2019 (UTC)
What about armor pieces that unlock skins for the three weights? Those aren't represented in the infobox, yet it's the same issue.
Also, skin items have defaults too. If you want to use a Guild Cavalier skin, you have to consume the skin and then spend transmutation charges.--Lon-ami (talk) 19:59, 1 February 2019 (UTC)
"skin Optional. Name of the skin that the item uses according to the wardrobe". According to this definition at the template page everything is clear.
However, my point is that there are reasonable items which have two skins (in the case of Obsidian and Mistforged Obsidian weapons, explained above). They just have to went with one skin (which of course, no surprise, is called default_skin in the api).
This doesn't hold for example for living world season armor rewards which also unlocks the skin for different armor classes. There at the moment of unlocking I cannot decide which skin I want, I have to change to another character, etc... --Tolkyria (talk) 20:14, 1 February 2019 (UTC)
I'm not against including that information on the infobox, but it should use a different slot from the main thing, and also cover cross-weight armor unlocks.--Lon-ami (talk) 13:33, 2 February 2019 (UTC)
May I specify my point a little bit more? Maybe the two skins per one item isn't quite correct... what I wanted to say is that if ingame there exists the option on a weapon Turn effects on/off they would have used it, see Sublime Mistforged Triumphant Hero's Raiment and any Obsidian weapons. But this isn't the case, so there are two skins with one only one is set as default, which according to the definition should be set to the skin parameter. I have to deal with it.
"I don't think the infobox is the right location to place this information." vs "I'm not against including that information on the infobox [...]."
So now basically you suggest that there should be a Property:Unlocks skins (or similar) (not sure why "we'll have to move "Unlocked by item" relationship to the skin infobox", I think the weapon infobox is the right place ) as well as a parameter unlocks skins and section Unlocks skins in the infobox with the following behaviour:
  • Not having the parameter unlocks skins should not display the section Unlocks skin, however the Property:Unlocks skin is set to the input of the parameter skin.
  • Having the parameter unlocks skins should display the section Unlocks skin and set the Property:Unlocks skin.
Seems fine to me... but this should definitely be approved by someone else.
P.S. The initiating edit was this: Template:Armor infobox edit regarding the Sublime Mistforged chest pieces; so this somehow motivated my reasoning. --Tolkyria (talk) 14:12, 2 February 2019 (UTC)
Yeah, that's the ideal solution. Weapons, back items, and armor, should only have one skin. The rest should be noted down outside the infobox, or in a separate section.
I'm also not sure how the "secondary skin unlock" process works. I think it's mostly linked to the skin (you can see this clearly with gem store armor sets being wholly unlocked by just getting the coat piece through the wardrobe unlocker), but there could be instances where it's linked to the item too. I would stick to the skin, adding the information inside the skin infoboxes, and then make item infoboxes retrieve it from the item pages.
Some consumable items let you apply the skin to multiple weights, gotta cover that somehow too, because these might not have a "default" skin, effectively having multiple skins at once, and breaking the above rule used for weapons, back items, and armor.--Lon-ami (talk) 16:15, 2 February 2019 (UTC)
There are two skin unlock sources, salvaging a piece of equipment or a consumable item that unlocks the skin. We can lookup equipment that unlocks a skin by looking at the default skin, but the rest of the information needs to be add on the item infobox or the skin infobox for the relationship. For stuff like salvaging, we put the relationship on the source item page. For something with multiple source types like recipes that have many-to-one, we put the relationship on destination page (aka the output item page). We can look up the source type by the item type.
Adding the information to the skin page seems more likely. This way is easier to manage since the code is in one place and less confusing for users on where to add the information.--Relyk ~ talk < 22:20, 8 February 2019 (UTC)
The new field could be called "unlocks", and include as many skins as we want. The "skin" field would only be allowed to include one skin (the default skin). Is that right with everybody?--Lon-ami (talk) 16:38, 9 February 2019 (UTC)
I am not sure why adding the information at the skin page should be easier and less confusing? Actually, to be honest, it sounds pretty confusing for me. So far the only real information that is set at a skin page is the skin id. The other parameters, as the name, the type, the icon and the set are still set, but somehow can be extracted by the name (up to some inconstencies, therefore it's more convenient to set it per hand). So now you want to set such important information at the skin infobox? Set the parameter Unlocked by in the skin infobox, just to ask for the same in the Acquistion section with {{skin list}}? Or, create a template {{Unlocked by|<item name>}} so one have to decide if he/she uses either {{Skin list}} to get the default skin or set the skin acquisition method with {{Unlocked by}} by hand. Now that really sounds confusing to me.
On the other hand, using Unlocks skins in the Weapon infobox results in one little change at {{Skin list}} (replace Has skin with Unlocks skin) and not a single skin page edit. --Tolkyria (talk) 17:32, 9 February 2019 (UTC)
(Reset indent) If multiple skins exist in the infobox, wouldn't it be easier to identify the first one with the suffix " (default)"? Personally I like the current layout but concede some demarcation of the default skin might be useful. -Chieftain AlexUser Chieftain Alex sig.png 17:43, 9 February 2019 (UTC)
{{#if: {{{skin|}}} |
;[[Skin]]
:{{#arraymap: {{{skin|}}} |;|@@@ |{{#vardefine:skinName|{{ifexists|@@@ (skin)|@@@ (skin)|@@@}}}}{{increment|skin count}}{{cname|{{#var:skinName}}}} {{#ifeq: {{#var:skin count}} | 1 | {{#if: {{#pos:{{{skin|}}}|;}} | ''(default)'' }} }}<!--{{#set: Has skin={{#var:skinName}}}}--> |<br>}}
}}
skin = Mistforged Obsidian Shield (skin)
Skin
Mistforged Obsidian Shield
skin = Mistforged Obsidian Shield (skin); Slumbering Mistforged Obsidian Shield (skin)
Skin
Mistforged Obsidian Shield (default)
Slumbering Mistforged Obsidian Shield
-Chieftain AlexUser Chieftain Alex sig.png 17:55, 9 February 2019 (UTC)
That was exactly my suggestion, I was just thinking too complicated again (by splitting the parameter skin into skin and unlocks skins). --Tolkyria (talk) 17:57, 9 February 2019 (UTC)
Edit: I would still suggest to split the properties, like this:
{{#if: {{{skin|}}} |
;[[Skin]]
:{{#vardefine: skinName | {{ifexists | {{#vardefineecho: skinDefault | {{#explode: {{{skin|}}} |;|0}} }} (skin) | {{#var:skinDefault}} (skin) | {{#var:skinDefault}} }}}} {{cname|{{#var:skinName}}}} {{#set: Has skin={{#var:skinName}}}} {{#set: Unlocks skin={{#var:skinName}}}}
{{#if: {{#vardefineecho: skinOthers | {{#explode: {{{skin|}}} |;|1}} }} |
;Unlocks skins<!-- optional, or just: ''(default)'' <br> -->
:{{#arraymap: {{#var:skinOthers}} |;|@@@ |{{#vardefine:skinName|{{ifexists|@@@ (skin)|@@@ (skin)|@@@}} }} {{cname|{{#var:skinName}}}} {{#set: Unlock skins={{#var:skinName}}}} |<br>}}
}} }}
--Tolkyria (talk) 22:14, 9 February 2019 (UTC)
That's a good idea too, just need to make sure the default skin is always first. No need to update every page, so even better.
Would be nice if a similar approach was used for armor pieces, the likes of Karka Helm Skin, making "(heavy)", "(medium)", and "(light)" appear next to each skin.--Lon-ami (talk) 00:41, 10 February 2019 (UTC)
So, are we good with the suggestions so far?--Lon-ami (talk) 15:11, 27 February 2019 (UTC)