Template talk:Related traits

Shadow Savior

This template currently does not list Shadow Savior for skills that are affected by it. --BuffsEverywhere (talk) 09:19, 4 June 2021 (UTC)

Trait skills filtering

This template does not filter out trait skills on Life stealing#Related traits. When filtering by profession, Lesser Signet of Vampirism is not filtered. However it is filtered when using the related skills filter in the section above. --BuffsEverywhere (talk) 00:42, 16 October 2021 (UTC)

The subtemplate had the wrong filter id. Fixed. --Tolkyria (talk) 08:12, 16 October 2021 (UTC)

The subheadings also don't appear to be removed when there's nothing pertaining to them with the current filter unlike with {{Related skills filter}}. Sunlion (talk) 08:23, 16 October 2021 (UTC)

Thanks for fixing that. An additional suggested feature might be making it so only one filter can be selected in the profession category, IE: "Elementalist, Traits, Trait skills" instead of "Elementalist, Guardian, Traits, Trait skills", with the intended result showing Elementalist traits and trait skills. Sunlion (talk) 08:58, 16 October 2021 (UTC)

As you already found out, should work now on game mechanic pages.

That's not possible because the widget filter options are AND, OR, ONLY but not a mixture of this. First, one can't tune down a single "category" to ONLY as there are no "categories" defined internally (that's just a plain text label), second, we cannot mix filter options as you are suggesting: Elementalist AND (Trait OR Trait skills). Beside coding this properly, how should a wiki user define this input? For example Elementalist AND (Trait OR Trait skills) is different from (Elementalist AND Trait) OR Trait skills, which would also require either parentheses or giving AND higher precedence than OR (which again isn't trivial at all for wiki users to work with it).

There are two reasonable ways to do it:

1. Keep AND in order to allow combinations out of "profession" and "context", e.g. Elementalist AND Trait, where exactly one of each category can be selected to yield a valid result (if there is a skill/trait of course).
2. Set it to ONLY, hence only one filter can be used at once. This would mean that only one profession can be selected, but also that you can't combine it with a context or "Hide headings".
3. Setting it to OR is not an option for me. For example Elementalist OR Trait would give elementalist skills as well as all traits regardless of the profession.

Thus, in my opinion AND is the best (and only) way to do it. --Tolkyria (talk) 09:19, 16 October 2021 (UTC)

AND would work, I agree. Sunlion (talk) 10:01, 16 October 2021 (UTC)

By the way, is there any reason Magnetic Aura isn't showing up under the related skills section for Reflect? Alongside this, might you possibly be able to create some sort of Related equipment template? Sunlion (talk) 10:28, 16 October 2021 (UTC)

Magnetic Aura isn't showing up because the skill fact shows the property Has fact type = Aura. When using the skill list/trait list on the reflect page, those templates consider that page as Has fact type = Special. So the Magnetic Aura is excluded from the search [[Has fact type::Special||Effect]]. --BuffsEverywhere (talk) 11:38, 16 October 2021 (UTC)

At this point I'm not sure if it made sense to split auras from the general common effects, but I'm also not sure what I need to adjust if I revert it.

Fortunately I added {{#ifeq: {{#var:type}}|+|<!-- no restriction -->|[[Has fact type::{{#var:type}}{{!!}}Effect]]}} back in the days when I created the templates, thus setting "type = +" together with "include effects = y" will select facts of any type, hence including "Auras".

I currently do not have any plans in formalizing anything related to equipment, for comparison I started with storing skill facts almost exactly two years ago with a rudimentary skill list template.

Now we have related skills/traits including a complete scheme to deal with informal trait descriptions ("improves" parameters) and filters as the lasted addition. Yet I have the feeling that we still aren't finished yet, the code still needs to be adjusted or improved. So again, no idea and I probably won't look into it in the near future. There is enough other wiki stuff to do: you guys are keeping me busy with the related skills/traits templates, next three beta professions are coming soon, ... --Tolkyria (talk) 17:59, 16 October 2021 (UTC)

Filter

Please note that today I changed the following:

• The parameter "hide filter" was renamed to "show filter" to avoid such wierd double negation constructs as "hide filter = false", now we set "show filter = true".
• The number of pages where the filter is shown automatically was massively turned down, now it is only shown on effect pages of type "Boon/Condition/Aura/Control effect" as those are used by a certain number of skills. All other random effects or game mechanics could be either used by many or simply by one skill, hence it's in the responsability of the wiki editor to enable the filter if necessary (e.g. 10+ skills).

Still to do:

• Enable filters for Skill list by property. - Edit: Done. --Tolkyria (talk) 19:10, 16 October 2021 (UTC)

--Tolkyria (talk) 09:19, 16 October 2021 (UTC)

Spear skills

It looks like land spear skills currently show traits that benefit aquatic spears in Related traits, as can be seen on Psycut with Fencer's Finesse (may have to purge the page). Sunlion (talk) 02:25, 27 June 2024 (UTC)

Hey Sunlion, welcome back! This is happening because both land and underwater spear skills have the same property Property:Is for weapon::Spear. I think one solution is to edit the Skill Infobox to set that property to underwater spear (since that is what anet is calling them in the trait description) for the underwater spear skills. Then edit the 4 traits that improves the underwater spears to | improves weapon = underwater spear. --BuffsEverywhere (talk) 03:53, 27 June 2024 (UTC)

At least for the skill page (see talk section) it looked like Alex wanted to use "aquatictwohand" vs "twohand" to differentiate? But we can still decide what works better for this too. --Dak393 (talk) 04:21, 27 June 2024 (UTC)

If we need to set a different weapon type, so be it, I just thought it would be nicer to set them to the same. Happy to re-bot everything, not that many pages, just tell me what you want. (btw since "Property:Is for weapon" has type:page, the underwater spear page can't be a redirect) -Chieftain Alex 05:13, 27 June 2024 (UTC)