Template talk:Trait icon/Archive 1

From Guild Wars 2 Wiki
Jump to: navigation, search

Needs tweaking[edit]

Wonder if anyone knows what's going on here. The background colour doesn't quite fill the inner white space. At first I thought it was because the height of the background didn't match the image hight. This didn't solve anything. Then I thought that the background was applied to the original size of the icon then reduced in the call. I uploaded a new icon that is 25x25, still didn't fix it. You can see here that all the common icons that use this template are suffering the same fault. I am not the greatest coder, so I"m fairly certain that I am missing something. Anyone have any further insight? Venom20 User Venom20-icon-0602-sm-black.png 14:39, 15 September 2010 (UTC)

Isn't the icon too big? The icon seems to center itself on text lines, meaning that it'll drop below the area where the background will apply. If you could try and place the icon on the text line (like above this → _ ) You can see the difference as well, when you apply the big thingies: #73efb0 #73efb0 (normal: #73efb0 #73efb0 ) ge4ce 14:54, 15 September 2010 (UTC)
I see what you mean there. I may need to add 2 spans instead of the one. In order to treat the background separately from the icon. I tried adding a top: -1px, but it shifted the entire icon with the background. Venom20 User Venom20-icon-0602-sm-black.png 15:45, 15 September 2010 (UTC)
i think i can fix this, will have a go at it. — Scythe 20:31, 15 Sep 2010 (UTC)
nice work venom! you didnt break it as bad as i did ^^. On a more relivant note, i think i was close. Calling poke 2, cuz at the level of #if: it is atm this point its making my head spin (as far as i can tell, its technicalities breaking it atm) — Scythe 22:44, 15 Sep 2010 (UTC)
Hah! Nicely broken. Well, your coding skills clearly out-shine mine, so I'm sure you can solve it. The table works for the colours, but then it screws up the spacing of multiples if using a "*" to create a bullet. Venom20 User Venom20-icon-0602-sm-black.png 22:48, 15 September 2010 (UTC)
^^ lookie here! its returning text just fine (i think, havent tried non-ambiguous things yet). only thing is neither image is returning, which is why i called poke. plus, it auto-inserts a <pre>-type effect after it, without a tag. I've gone over it a few times, and my head is spinning from too much {{{{{{{{}}}}}}}}}{}{}{{{}{}, which is why i called poke D: — Scythe 22:55, 15 Sep 2010 (UTC)
actually, no i tested it. Its completely fucked :(. Alternativly, did you know Template:skill icon Does the same thing, w/e being broken? — Scythe 22:59, 15 Sep 2010 (UTC)
Have you tried a div that floats left and is exactly the size of the image (sandbox)? --JonTheMon 00:16, 16 September 2010 (UTC)

(Reset indent) @ Scythe, Yeah, we were using skill icon temporarily for traits. But skill icon uses jpg's and the traits should be png's so that the inner surface can be transparent for the classes that hare the same trait. That's the main purpose of this trait template. Venom20 User Venom20-icon-0602-sm-black.png 00:34, 16 September 2010 (UTC)

Why enclose it in a table? --JonTheMon 20:28, 16 September 2010 (UTC)
I think I've got a solution that works. I pretty much used the span version and added a padding-bottom to it. I used it in both a table and with bullet points User:JonTheMon/sandbox --JonTheMon 14:29, 17 September 2010 (UTC)
Yes, that looks like it could work. Who knew it could be so simple. Thanks JonTheMon ­­­­­Venom20 User Venom20-icon-0602-sm-black.png 15:09, 17 September 2010 (UTC)
jon, ilu <3 — Scythe 0:47, 18 Sep 2010 (UTC)

Recommendation to delete[edit]

I think we should delete the current template and, when we need it again, start from scratch:

  1. The template is currently unused in the mainspace.
  2. There aren't any relevant PNG files for traits that it can call.
  3. There are some syntax issues that require fixing. (Some of which would be resolved by naming two optional parms: color (currently unnamed) and link name (so that the trait name can display without disambig, but link to to the correct file and article).

Tennessee Ernie Ford (TEF) 17:11, 17 May 2012 (UTC)

Is deletion absolutely required to make the noted changes to this template? Likely not; feel free to commence overhauls to keep the template up to date.
Another argument not to delete it is to show the development process of both in the game and on the wiki in the template's history. - Infinite - talk 10:57, 21 May 2012 (UTC)
My point is that fixing this template means starting from scratch; I don't understand why we would keep it. In response to the above arguments:
  • There is nothing to keep up-to-date; it is broken now, but it's not in-use.
  • There's no development here; this was a copy/paste job from other, similar templates.
It's more confusing to leave the template on the wiki in its current state than to delete it. Essential? No more so than deleting redirects after a move. – Tennessee Ernie Ford (TEF) 00:15, 22 May 2012 (UTC)
I meant it more along the lines of; because it already isn't used, this template can be edited freely without the fear of breaking articles in main space. Why, specifically, does it merit a full deletion just to redo the template (with the exact same use). Do we really need to wait for an admin to delete it to make it better now? - Infinite - talk 22:32, 27 May 2012 (UTC)